Add 'superseded by ImagePresentationComponent' status note; StereoPair: Equatable#2
Open
halmueller wants to merge 1 commit into
Open
Add 'superseded by ImagePresentationComponent' status note; StereoPair: Equatable#2halmueller wants to merge 1 commit into
halmueller wants to merge 1 commit into
Conversation
…oPair: Equatable
Add a Status section explaining this 2024 (visionOS 2.0) ShaderGraphMaterial +
CameraIndexSwitch sample is superseded by visionOS 26's ImagePresentationComponent
(.spatialStereo), and why (texture-swap leaks, sync TextureResource.load on the
render thread, the grayscale-load bug, no depth/convergence control, fixed plane
aspect). Points to the productized spatial-HEIC successor.
Conform StereoPair to Equatable (it already defined a free `==` without declaring
conformance). Builds clean ("SG Stereo revised", visionOS 26.5 SDK) — the two
StereoView files live in separate targets, so there is no duplicate-symbol error.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Minimal, non-behavioral update to mark this 2024 sample's status and fix one type-system gap.
ShaderGraphMaterial+CameraIndexSwitchapproach (visionOS 2.0 / Xcode 16.2) is superseded by visionOS 26'sImagePresentationComponentwith.spatialStereo, and why — texture-swap memory leaks, synchronousTextureResource.loadon the render thread, the grayscale-load bug (FB13733823) patched with the blue-streak hack, no depth/convergence control (wide-baseline pairs like several Middlebury 2021 scenes are uncomfortably deep), and the fixed plane aspect. Points to the productized spatial-HEIC successor.Equatableconformance (it already defined a free==without declaring it).Notes
StereoViewbuild error:StereoView_revised.swiftandStereoView_simple.swiftare each compiled by their own target ("SG Stereo revised" / "SG Stereo simple"), not both in one — so they don't collide.🤖 Generated with Claude Code