[services] Update pod priorities and give grafana a realistic memory request#15357
Open
cjllanwarne wants to merge 2 commits intohail-is:mainfrom
Open
[services] Update pod priorities and give grafana a realistic memory request#15357cjllanwarne wants to merge 2 commits intohail-is:mainfrom
cjllanwarne wants to merge 2 commits intohail-is:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts Kubernetes scheduling priorities and resource sizing for cluster monitoring/CI components to reduce batch-driver evictions and improve node packing behavior based on resource requests.
Changes:
- Introduces a new
auxiliaryPriorityClass and assigns it to Prometheus, Grafana, Monitoring, and CI (deploy only). - Updates Grafana pod scheduling so test/non-deploy runs on preemptible nodes, and increases Grafana memory requests while tightening limits.
- Bumps Prometheus to
v2.53.5pinned by digest.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| prometheus/prometheus.yaml | Moves Prometheus to auxiliary priority (deploy) and bumps Prometheus image to 2.53.5 (digest-pinned). |
| monitoring/deployment.yaml | Assigns Monitoring deployment to auxiliary priority. |
| grafana/deployment.yaml | Moves Grafana to auxiliary, makes deploy/non-deploy node placement explicit, and updates resource requests/limits. |
| ci/deployment.yaml | Changes CI priority class to auxiliary for deploy environments. |
| ci/bootstrap.yaml | Adds the new cluster-scoped auxiliary PriorityClass definition. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kush-chandra
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Fixes #15339
The batch-driver node has been evicted multiple times from the node it's been running on, leaving a trail of
ErrorandContainerStatusUnknownpods in the cluster.A couple of issues together seem likely to cause this:
grafanapods (including from test namespaces), andprometheus-0, which are all marked asinfrastructurepriority (above batch-driver which is "only"production).Therefore this change:
To think about if prometheus starts hitting WAL problems more often:
infra/gcp-broadprojects are still using n1-standard-2 VMs (unlike gcp/ projects which are on n1-standard-4). That's slightly cheaper, but each node only gets a max of 5.7GB to play with - and in this case that wasn't enough for prometheus to catch up with its WAL. Switching to n1-standard-4 would give a higher cap of 10+G to expand into.Warning
This change requires a manual addition to the priorityclasses set in kubernetes before rollout.
The following priorityclass addition must be manually applied (or ci/bootstrap.yaml can be re-applied, but
verify with --dry-run=server first)
Security Assessment
Delete all except the correct answer:
Impact Rating
Delete all except the correct answer:
Impact Description
Just internal pod re-prioritization, and a prometheus update
Appsec Review