[query/vds] Reflow VDS validate method#15349
Open
chrisvittal wants to merge 5 commits intohail-is:mainfrom
Open
[query/vds] Reflow VDS validate method#15349chrisvittal wants to merge 5 commits intohail-is:mainfrom
chrisvittal wants to merge 5 commits intohail-is:mainfrom
Conversation
Split out each validation component into its own method.
chrisvittal
force-pushed
the
query/vds/cleaner-validate
branch
from
3e28bb4 to
151f4a3
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
ehigham
approved these changes
Mar 20, 2026
Member
ehigham
left a comment
ehigham
left a comment
There was a problem hiding this comment.
This is a really nice change. Much more readable. Thank you.
patrick-schultz
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out each validation component into its own method. The
check_databranch remains one method as it is one aggregation pipeline.Security Assessment