Skip to content

[compiler] Fix toFastSeq to not copy a WrappedArray or ArraySeq#15344

Open
patrick-schultz wants to merge 1 commit intohail-is:mainfrom
patrick-schultz:ps/push-myqlrksntswx
Open

[compiler] Fix toFastSeq to not copy a WrappedArray or ArraySeq#15344
patrick-schultz wants to merge 1 commit intohail-is:mainfrom
patrick-schultz:ps/push-myqlrksntswx

Conversation

@patrick-schultz
Copy link
Member

Change Description

This had been my intention in the first place. to was correctly avoiding copies in 2.13, but not 2.12. Now we call ArraySeq.from, which we wrote ourselves to avoid copies. This is most useful in the pattern

def foo(args: T*) {
  expectsIndexedSeq(args.toFastSeq)
}

where args is a WrappedArray.

Security Assessment

  • This change cannot impact the Hail Batch instance as deployed by Broad Institute in GCP

@ehigham ehigham added this to the 0.2.138 milestone Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants