Skip to content

Conversation

@bltomlin
Copy link
Member

@bltomlin bltomlin commented Feb 5, 2025

Fixes #103

What changes did you make?

  • added AWS privs

Why did you make the changes (we will use this info to test)?

  • onboarding

@bltomlin bltomlin self-assigned this Feb 5, 2025
@bltomlin
Copy link
Member Author

bltomlin commented Feb 5, 2025

ready for a second review

Copy link
Member

@ale210 ale210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

take a look at:
https://github.com/hackforla/devops-security/pull/103/files

the tfstate file is still listed in what would be changed. also, please remove aws-user.tf and the deletions (in red) from aws-users.tf. The listed url should have only green in one file.

@github-actions
Copy link

github-actions bot commented Feb 5, 2025

Terraform plan in terraform
With backend config files: terraform/prod.backend.tfvars

Plan: 3 to add, 0 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+   create

Terraform will perform the following actions:

  # module.iam_user_bltomlin.aws_iam_user.user will be created
+   resource "aws_iam_user" "user" {
+       arn           = (known after apply)
+       force_destroy = false
+       id            = (known after apply)
+       name          = "bltomlin"
+       path          = "/"
+       tags          = {
+           "Access Level" = "1"
+           "Project"      = "devops-security"
        }
+       tags_all      = {
+           "Access Level" = "1"
+           "Project"      = "devops-security"
        }
+       unique_id     = (known after apply)
    }

  # module.iam_user_bltomlin.aws_iam_user_group_membership.user_group_membership will be created
+   resource "aws_iam_user_group_membership" "user_group_membership" {
+       groups = [
+           "read-only-group",
        ]
+       id     = (known after apply)
+       user   = "bltomlin"
    }

  # module.iam_user_bltomlin.aws_iam_user_login_profile.user_login will be created
+   resource "aws_iam_user_login_profile" "user_login" {
+       encrypted_password      = (known after apply)
+       id                      = (known after apply)
+       key_fingerprint         = (known after apply)
+       password                = (known after apply)
+       password_length         = 20
+       password_reset_required = true
+       user                    = "bltomlin"
    }

Plan: 3 to add, 0 to change, 0 to destroy.

✅ Plan applied in Apply Terraform changes on merge #23

@ale210 ale210 merged commit 4a6a7a1 into main Feb 5, 2025
1 check passed
@ale210 ale210 deleted the issue-102-add-new-iam-user branch February 5, 2025 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants