Add FFFA to magic bytes for MP3. Fixes #10#11
Open
maugre wants to merge 6 commits intoh2non:masterfrom
Open
Conversation
Owner
|
Looking good. It would be perfect if you can provide a fixture file for a test scenario. |
Author
|
Added sample file and some extra tests. Some tests fail, which I guess is using the old matcher function. The same tests pass locally with patched matcher function. |
|
Will take a look in detail sometime this weekend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves the problem for me with mono-channel MP3 files. Please let me know if any changes are required, e.g. for code style. Thanks.