AnimationBuilder inserts identity scale keys instead of rest pose scale when scale track is missing

[nicugnm]

Missing scale tracks default to (1,1,1) instead of skeleton rest pose scale

Description

When building an animation that contains translation and/or rotation keys but no scale keys for a bone, AnimationBuilder generates two implicit scale keys using ScaleKey::identity() ((1,1,1)).

This happens in CopyRaw() when _src.size() == 0, where PushBackIdentityKey() is called for scale tracks:

if (_src.size() == 0) {
PushBackIdentityKey<SrcKey, _DestTrack>(_track, 0.f, _dest);
PushBackIdentityKey<SrcKey, _DestTrack>(_track, _duration, _dest);
}

PushBackIdentityKey() constructs the key using:

_SrcKey::identity()

For scale keys, this resolves to:

ScaleKey::identity() { return math::Float3::one(); } // (1,1,1)

Problem

This ignores the skeleton’s rest pose scale. If the rest pose scale is not (1,1,1) (e.g. negative or non-uniform scales like (-1.43, 1, 1)), the generated animation will override the rest pose scale and produce incorrect results.

Expected behavior

When a scale track is missing, the builder should use the skeleton rest pose scale for that joint, not a hardcoded identity scale.

Impact

This breaks animations for rigs that rely on non-identity rest pose scales, even when scale is intentionally not animated.

[guillaumeblanc]

Hi,

I understand the need, but solved it another way. See gltf importer for example.

AnimationBuilder doesn't know the skeleton. It's users' responsibility to fill tracks with the appropriate data. In this case, you can add a single scale key with the value coming from the skeleton.

Does that work?

Hope it helps,
Guillaume

[guillaumeblanc]

Hi,

did you maange to try ? any feedback ?

Cheers,
Guillaume

[nicugnm]

Hey,

I managed to fix it, thank you. But dropped to use ozz-animation as it works very slow to my use-case. Performance is not what i expected. :/