unix_fd_add: Port to safe-io

[A6GibKm]

From #871.

[A6GibKm]

From #871 (comment):

@sdroege: I think these functions all need to be unsafe actually. impl AsFd is correct but it's up to the caller to ensure that the fd is valid long enough

In that case would it not be better to pass an OwnedFd? The docs for unix_fd_add or unix_fd_add_full don't say much.

[sdroege]

In that case would it not be better to pass an OwnedFd? The docs for unix_fd_add or unix_fd_add_full don't say much.

Good question. But can you get an OwnedFd for stdin, for example?

[sdroege]

Also, shouldn't the GSource trigger when it's closed and be destroyed then? From inside GLib I mean.

[A6GibKm]

In that case would it not be better to pass an OwnedFd? The docs for unix_fd_add or unix_fd_add_full don't say much.

Good question. But can you get an OwnedFd for stdin, for example?

If you mean std::io::Stdin then it implements AsFd from which you can call https://doc.rust-lang.org/std/os/fd/struct.BorrowedFd.html#method.try_clone_to_owned.

[sdroege]

I think the main question here is what happens with the GSource if the fd is closed. Random things? Does the GSource get destroyed cleanly?

[sdroege]

@A6GibKm This would need to be handled in the next weeks if it should end up in the next release