You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This doesn't seem right to me. Even for static libraries, you want the -sys crate to "link" it so that the static library ends up being linked into the final build result.
This seems to be specific to how libgnome-games-support works, but I'm not sure what exactly that is. Can you explain the exact problems you're trying to solve here?
Can you explain the exact problems you're trying to solve here?
libgnome-gamers-support is a copylib, meaning its distribution is done by building it as meson subproject and statically linking it, instead of installing the library.
Even for static libraries, you want the -sys crate to "link" it so that the static library ends up being linked into the final build result.
Yes, I removed the linking step because I wanted to get my bindings to build without the subproject. I will fix that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does what is necessary for static library bindings to work.
This is used by libgnome-games-support-rs.