Open
Conversation
This was referenced Mar 1, 2023
Member
|
Can you make a draft PR with the changes this causes in the generated code? |
pbor
reviewed
Mar 1, 2023
Member
|
What also might be worth considering here is parameters.
This might also be something to handle in a separate PR though. |
604ccc7 to
95ecf2c
Compare
Member
Author
|
Those should be handled in #1448 |
This was referenced Mar 5, 2023
sdroege
reviewed
Mar 11, 2023
Member
Member
|
Looks good to me otherwise, if that wasn't clear. How should we proceed? :) |
Member
Author
|
Sorry for delay, I did some more testing and this is looking good for me too. But I think this situation should be resolved first: gtk-rs/gtk-rs-core#1078 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is there a better way to get the actual type of a C array from the builder? The best I could do is adding the
c_typelike this.I left the
Vec<OsString>andVec<PathBuf>return as is, since those require allocations and they are opt-in.