Replace builders with generated traits on ObjectBuilder#1417
Draft
jf2048 wants to merge 1 commit intogtk-rs:mainfrom
Draft
Replace builders with generated traits on ObjectBuilder#1417jf2048 wants to merge 1 commit intogtk-rs:mainfrom
jf2048 wants to merge 1 commit intogtk-rs:mainfrom
Conversation
jf2048
force-pushed
the
builder-traits
branch
3 times, most recently
from
17e6a81 to
37eb9a1
Compare
| module_name, analysis.name | ||
| "\tpub use super::{}::{}BuilderExt;", | ||
| module_name, | ||
| analysis.builder_trait_prefix() |
Member
There was a problem hiding this comment.
Can't this return the actual builder trait name instead?
Member
Author
There was a problem hiding this comment.
Which one? I had to do something like this because otherwise it gets the same conflicts as with the normal trait names (e.g. ObjectExt WindowExt ApplicationExt, etc)
sdroege
reviewed
Dec 11, 2022
Member
sdroege
left a comment
sdroege
left a comment
There was a problem hiding this comment.
Looks generally good to me, nice cleanup :)
Can you create a PR to show the changes before we merge this here?
Member
Author
|
I think something needs to be done in gtk-rs-core about the missing |
Member
Author
|
Sorry meant gtk3-rs and gtk4-rs, those seem to be the only places using it |
jf2048
force-pushed
the
builder-traits
branch
from
37eb9a1 to
1485bdd
Compare
This was referenced Dec 19, 2022
Member
|
@jf2048 @bilelmoussaoui What's the plan/status here? |
Member
Author
|
It is a real pain to modify that wrapper macro to do what we need to do here |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternate solution to #1391. Tested with gtk4 it removes around 40,000 lines of code.
I had to remove
builder_postprocesstoo. For that I would like to somehow come up with a way to fold the setup intoFromGlibPtrandFromValue.