Support BoxedInline without a get_type function by wash2 · Pull Request #1297 · gtk-rs/gir

wash2 · 2021-12-29T22:44:42Z

This is my attempt at supporting BoxedInline without a get_type function #1236 #1295. Generating the bindings for gmodule does not panic and now outputs:

[WARN  libgir::analysis::functions] Function g_module_symbol has unsupported outs
[WARN  libgir::analysis::functions] Function g_module_open_full has unsupported outs
[ERROR libgir::analysis::record] Missing memory management functions for GModule.Module

sdroege · 2021-12-30T07:57:58Z

src/codegen/general.rs

-        sys_crate_name,
-        get_type_fn
-    )?;
+    if let Some((ref get_type_fn, _get_type_version)) = get_type_fn {


This requires a get_type function, or otherwise more changes in glib are needed

For the case of not BoxedInline but normal Boxed

So the get_type_fn here can't be None then?

Well, there won't be a copy/free function here otherwise and that won't compile without further changes in glib

sdroege · 2021-12-30T07:59:40Z

src/library.rs

            }
            if let Some(tid) = env.library.find_type(0, &full_name) {
-                let gobject_id = env.library.find_type(0, "GObject.Object").unwrap();
+                let gobject_id = env.library.find_type(0, "GObject.Object");


If you don't have GObject in your dependencies then there can't be any class hierarchy at all, so the code below should simply not run

sdroege

Otherwise makes sense.

Why do you want to create bindings for GModule though? I think that's going to require writing the whole bindings manually to end up with anything usable and somewhat safe. The autogenerated bindings won't be usable.

bilelmoussaoui · 2021-12-30T08:20:31Z

src/codegen/record.rs

+            &analysis.init_function_expression,
+            &analysis.copy_into_function_expression,
+            &analysis.clear_function_expression,
+            &analysis.glib_get_type,


maybe analysis.glib_get_type.map(|ref a,_| a) or something like that to avoid passing the version that's unneeded here ?

wash2 · 2021-12-30T15:26:55Z

Why do you want to create bindings for GModule though? I think that's going to require writing the whole bindings manually to end up with anything usable and somewhat safe. The autogenerated bindings won't be usable.

I want to use GModule to support "plug-ins"
I was not aware that the auto-generated bindings would not be usable, but I could try manually writing safe bindings if necessary.

sdroege · 2021-12-30T15:40:19Z

I was not aware that the auto-generated bindings would not be usable

The -sys bindings should be fine, the non-sys ones probably only have very few functions generated and you'll have to be very careful here with memory safety. Take a look at all the complications in the libloading API for example.

wash2 · 2021-12-30T16:12:35Z

I was not aware that the auto-generated bindings would not be usable

The -sys bindings should be fine, the non-sys ones probably only have very few functions generated and you'll have to be very careful here with memory safety. Take a look at all the complications in the libloading API for example.

Ok, thanks, I'll check that out

bilelmoussaoui

Wouldn't this work ?

bilelmoussaoui · 2021-12-30T16:17:48Z

src/codegen/general.rs

    copy_into_function_expression: &Option<String>,
    clear_function_expression: &Option<String>,
-    get_type_fn: &str,
+    get_type_fn: Option<&String>,


Suggested change

get_type_fn: Option<&String>,

get_type_fn: Option<&str>,

bilelmoussaoui · 2021-12-30T16:18:05Z

src/codegen/record.rs

+            &analysis.init_function_expression,
+            &analysis.copy_into_function_expression,
+            &analysis.clear_function_expression,
+            analysis.glib_get_type.as_ref().map(|(ref a, _)| a),


Suggested change

analysis.glib_get_type.as_ref().map(|(ref a, _)| a),

analysis.glib_get_type.as_ref().map(|(ref a, _)| a).as_deref(),

Coercion still fails for me with as_deref()

wash2 added 2 commits December 29, 2021 11:35

fix gtk-rs#1295

b0961a9

cleanup

d0d61bf

wash2 changed the title ~~Support BoxedInline without a get_type function #1295 #1236~~ Support BoxedInline without a get_type function Dec 29, 2021

formatting

7883fe5

sdroege reviewed Dec 30, 2021

View reviewed changes

sdroege linked an issue Dec 30, 2021 that may be closed by this pull request

Panic on GIR not_bound mode for GModule #1295

Open

bilelmoussaoui reviewed Dec 30, 2021

View reviewed changes

wash2 added 2 commits December 30, 2021 10:06

unwrap on find_type

d2b27b6

avoid passing unneeded version

d174208

bilelmoussaoui reviewed Dec 30, 2021

View reviewed changes

use &str

2d06071

bilelmoussaoui mentioned this pull request Jan 1, 2022

Support BoxedInline without a get_type function #1236

Closed

	analysis.glib_get_type.as_ref().map(\|(ref a, _)\| a),
	analysis.glib_get_type.as_ref().map(\|(ref a, _)\| a).as_deref(),

Uh oh!

Conversation

wash2 commented Dec 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sdroege left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wash2 commented Dec 30, 2021

Uh oh!

sdroege commented Dec 30, 2021

Uh oh!

wash2 commented Dec 30, 2021

Uh oh!

bilelmoussaoui left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

wash2 commented Dec 29, 2021 •

edited

Loading