Instead of taking an &str take into<GString>#1184
Open
JAicewizard wants to merge 8 commits intogtk-rs:mainfrom
Open
Instead of taking an &str take into<GString>#1184JAicewizard wants to merge 8 commits intogtk-rs:mainfrom
&str take into<GString>#1184JAicewizard wants to merge 8 commits intogtk-rs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be completely compatible with the old generated code, however I have not looked at all cases. Cases I did explicitly look at are:
&strparametersOption<&str>parameters&strstill take&strIt would be ideal if there was some kind of
&GStr, to avoid hacking aroundref_modelike in this patch.