Add Page padding bottom xlarge - #544
Draft
jcfilben wants to merge 346 commits into
Draft
Conversation
add error validation to color
Update validation-critical placement and update yarn.lock
update margins based on Slack thread 5-12-2020
add size for dateinput icon
Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com>
add margin to drop
Update status colors to figma
* updated v8 theme for code blocks colors * remove font weight adjustments from pop theme * remove extra changes * Update package.json
🦋 Changeset detectedLatest commit: 703398f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jcfilben
marked this pull request as draft
October 6, 2025 19:42
Collaborator
Author
|
We will re-visit this behavior later, not for v8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds xlarge padding to the bottom of the Page component
What testing has been done on this PR?
Any background context you want to provide?
What are the relevant issues?
Screenshots (if appropriate)
Is this change backward compatible or could it be a breaking change for the official HPE theme?
How should this PR be communicated in the release notes?