Fix padded checkboxes: anchor border/tick to the input element. - #2300
Merged
Conversation
Small CSS fix in the checkbox component: the border and tick are now positioned relative to the input itself rather than an outer ancestor. Also remove two callers' workarounds for the same issue. Adds a Storybook example for checkboxes inside a padded wrapper, the case where the misalignment was visible.
berhalak
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small CSS fix in the checkbox component: the border and tick are now positioned relative to the input itself rather than an outer ancestor. Also remove two callers' workarounds for the same issue.
Adds a Storybook example for checkboxes inside a padded wrapper, the case where the misalignment was visible.
Context
If a component like
labeledSquareCheckboxis styled to include padding, its rendering has been broken: the tick is misplaced. This PR fixes it.Proposed solution
Adds
position: relativeto the checkbox input element.Has this been tested?
No automated test for this css-only change, but a storybook example is added, which looks wrong without the change, and is fixed by it.
Screenshots / Screencasts
Storybook example before the fix (note the radio workaround that's corrects it):
Storybook with the fix (the radio workaround removed, but is still correct):
