Skip to content

Spotandjake/gc stdlib#2364

Merged
ospencer merged 27 commits intooscar/gc-rebasedfrom
spotandjake/gc-stdlib
Mar 28, 2026
Merged

Spotandjake/gc stdlib#2364
ospencer merged 27 commits intooscar/gc-rebasedfrom
spotandjake/gc-stdlib

Conversation

@spotandjake
Copy link
Copy Markdown
Member

@spotandjake spotandjake commented Mar 1, 2026

No description provided.

@spotandjake spotandjake force-pushed the spotandjake/gc-stdlib branch from 030212b to bac0d78 Compare March 1, 2026 01:09
spotandjake
spotandjake commented Mar 1, 2026
View reviewed changes
Comment thread compiler/test/stdlib/bytes.test.gr
Comment thread compiler/test/stdlib/buffer.test.gr
Comment thread stdlib/runtime/atof/parse.gr
Comment thread stdlib/runtime/atof/parse.gr
Comment thread stdlib/runtime/unsafe/conv.gr
Comment thread stdlib/runtime/unsafe/tags.gr
Comment thread stdlib/runtime/equal.gr
Comment thread stdlib/runtime/string.gr
Comment thread stdlib/map.gr
8n
)
ignore(array)
arr[i] = (key, value)
Copy link
Copy Markdown
Member Author

@spotandjake spotandjake Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to consider doing this in more of the places we are doing Array.setAnyValue

Copy link
Copy Markdown
Member

@ospencer ospencer Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, but setAny avoids the bounds checks.

Copy link
Copy Markdown
Member Author

@spotandjake spotandjake Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats true. I think it makes sense to leave this one at least, I feel like Map.toArray is unlikely to be the bottleneck in user code and it greatly simplifies this function.

ospencer
ospencer reviewed Mar 4, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@ospencer ospencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work here, we're super close now!

Comment thread compiler/test/runtime/unsafe/wasmi32.test.gr
Comment thread docs/contributor/data_representations.md Outdated
Comment thread stdlib/bytes.gr Outdated
Comment thread stdlib/bytes.gr Outdated
Comment thread stdlib/bytes.gr Outdated
Comment thread stdlib/runtime/string.gr
Comment thread stdlib/runtime/unsafe/conv.gr
Comment thread stdlib/runtime/unsafe/wasmref.gr Outdated
Comment thread stdlib/runtime/unsafe/wasmref.gr Outdated
Comment thread stdlib/wasi/process.gr
@spotandjake
Copy link
Copy Markdown
Member Author

spotandjake commented Mar 5, 2026

I just pushed a new commit addressing all your pr feedback (except the merging ptr and i as i'm not sure that makes sense).

NOTEABLE CHANGES:

  • I made validate only log the wasm code itself in verbose mode
    • I've found it unhelpful working on this pr as it hides the actual validation errors binaryen emits which are more helpful when solving the error.
  • I did some additional cleanup of unused code for typeMetadata which was just wrong (I found this when making the metadata change).
  • I noticed that debugPrint wasn't actually printing to stdout causing incosistent behaviour.

These changes aren't completely related to your feedback but I figured they made sense to fix once I found them.

@spotandjake spotandjake force-pushed the spotandjake/gc-stdlib branch from b6d7528 to 5414788 Compare March 10, 2026 15:22
ospencer
ospencer reviewed Mar 28, 2026
View reviewed changes
Comment thread docs/contributor/low_level_programming.md Outdated
Comment thread docs/contributor/low_level_programming.md Outdated
Comment thread stdlib/runtime/atof/decimal.gr
Comment thread stdlib/runtime/atof/slow.gr
Comment thread stdlib/runtime/atof/table.gr
Comment thread stdlib/runtime/unsafe/wasmref.gr Outdated
Comment thread stdlib/runtime/unsafe/wasmref.gr Outdated
Comment thread stdlib/runtime/unsafe/wasmref.gr Outdated
Comment thread stdlib/runtime/unsafe/wasmref.gr Outdated
Comment thread stdlib/wasi/process.gr
@spotandjake spotandjake self-assigned this Mar 28, 2026
@spotandjake spotandjake added the gc label Mar 28, 2026
@spotandjake spotandjake force-pushed the spotandjake/gc-stdlib branch from ccbf105 to d8fa4bc Compare March 28, 2026 19:00
@ospencer ospencer merged commit 0d9ce55 into oscar/gc-rebased Mar 28, 2026
3 checks passed
@ospencer ospencer deleted the spotandjake/gc-stdlib branch March 28, 2026 19:12
spotandjake added a commit that referenced this pull request Mar 31, 2026
@spotandjake
Jake's gc stdlib updates (#2364)
b2cce3d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ospencer ospencer ospencer left review comments

@peblair peblair Awaiting requested review from peblair peblair is a code owner

@phated phated Awaiting requested review from phated phated is a code owner

@alex-snezhko alex-snezhko Awaiting requested review from alex-snezhko alex-snezhko is a code owner

@marcusroberts marcusroberts Awaiting requested review from marcusroberts marcusroberts is a code owner

Assignees

@spotandjake spotandjake

Labels

gc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@spotandjake @ospencer