feat(package/gqty): Add isFetching to proxy states#2303
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an isFetching property to proxy states in the gqty package, enabling real-time tracking of fetch operations for GraphQL queries. The feature uses a reference-counting mechanism with cache keys to track active fetches across nested selections.
Key Changes
- Implemented global fetch tracking using a Map with cache key reference counting
- Added
isFetchingas a lazy-evaluated getter property on Meta objects - Integrated fetch lifecycle management in the selection resolution process with proper cleanup
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
packages/gqty/test/isFetching.test.ts |
Comprehensive test suite covering concurrent fetches, nested selections, error handling, and edge cases |
packages/gqty/src/Selection.ts |
Implements global fetch tracking map with increment/decrement functions for cache keys |
packages/gqty/src/Client/resolveSelections.ts |
Manages fetch lifecycle by incrementing counters before fetches and decrementing in finally block |
packages/gqty/src/Accessor/resolve.ts |
Defines isFetching as a getter property on object and array accessors |
packages/gqty/src/Accessor/meta.ts |
Adds isFetching: boolean to the Meta type definition |
.changeset/red-cougars-jam.md |
Declares version bump for the feature (incorrect package reference) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.