Skip to content

feat(package/gqty): Add isFetching to proxy states#2303

Open
vicary wants to merge 4 commits intomainfrom
feat(package/gqty)-$meta-isFetching
Open

feat(package/gqty): Add isFetching to proxy states#2303
vicary wants to merge 4 commits intomainfrom
feat(package/gqty)-$meta-isFetching

Conversation

@vicary
Copy link
Copy Markdown
Member

@vicary vicary commented Dec 11, 2025

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds an isFetching property to proxy states in the gqty package, enabling real-time tracking of fetch operations for GraphQL queries. The feature uses a reference-counting mechanism with cache keys to track active fetches across nested selections.

Key Changes

  • Implemented global fetch tracking using a Map with cache key reference counting
  • Added isFetching as a lazy-evaluated getter property on Meta objects
  • Integrated fetch lifecycle management in the selection resolution process with proper cleanup

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/gqty/test/isFetching.test.ts Comprehensive test suite covering concurrent fetches, nested selections, error handling, and edge cases
packages/gqty/src/Selection.ts Implements global fetch tracking map with increment/decrement functions for cache keys
packages/gqty/src/Client/resolveSelections.ts Manages fetch lifecycle by incrementing counters before fetches and decrementing in finally block
packages/gqty/src/Accessor/resolve.ts Defines isFetching as a getter property on object and array accessors
packages/gqty/src/Accessor/meta.ts Adds isFetching: boolean to the Meta type definition
.changeset/red-cougars-jam.md Declares version bump for the feature (incorrect package reference)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

vicary and others added 2 commits December 11, 2025 23:04
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants