Draft
Conversation
Co-authored-by: kleberbaum <kleber@snek.at>
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
@kleberbaum In #2056 I can see that My questions mainly goes around the necessity of exporting # Hypothetical GraphQL schema
type Mutation {
foo(
required: String!
optional: String
): String
}// Pylon implementation
export const graphql = {
Mutation: {
foo(required: String, optional?: String) => {
return `${required}, ${optional}`;
}
}
};Currently GQty generates a mutation schema similar to the section below: export interface Mutation {
foo: (args: {
required: string;
optional?: string | null;
}) => ScalarsEnums['String'];
}As Pylon is built with TypeScript, required parameters must come before optionals. While we may optionally assert this fact during codegen, should it work if the generated schema exports something like this? export interface Mutation {
foo: (required: string, optional?: string) => string;
}If the type above looks good, we can hide the implementation details in a generic converter which reads the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This may supersedes #2056, adding @kleberbaum as a co-author.
@gqty/pylonwith input conversion utilitiesThe main goal is to avoid introducing schema changes unless absolutely required.