Skip to content

IQ Tool: QFileSystemWatcher, tolerate directory changes - #1237

Draft
willcode wants to merge 1 commit into
gqrx-sdr:masterfrom
willcode:feature/iq-tool-filewatcher
Draft

IQ Tool: QFileSystemWatcher, tolerate directory changes#1237
willcode wants to merge 1 commit into
gqrx-sdr:masterfrom
willcode:feature/iq-tool-filewatcher

Conversation

@willcode

@willcode willcode commented May 7, 2023

Copy link
Copy Markdown
Contributor
  • Use QFileSystemWatcher instead of polling
  • Sort by time instead of name
  • Rec time is not dependent on dir contents
  • Gray out more widgets while recording

This is similar to #1164 and part of #1171 together, with some added tolerance for files changing during recording or being named as if they were recorded in the future.

@willcode
willcode force-pushed the feature/iq-tool-filewatcher branch from 5717074 to 04782e3 Compare May 7, 2023 12:55
@vladisslav2011

Copy link
Copy Markdown
Contributor

I suggest adding a context menu to the file list to make file sorting order/property configurable by the user.
Sometimes it may be better to sort by creation/modification time, but as file name contains it's recording time, sorting by name effectively sorts by creation time.

@willcode

willcode commented May 7, 2023

Copy link
Copy Markdown
Contributor Author

Good idea. There's still a problem to deal with, which is why I made it by creation time. The tool specifically looks at the last line in the list to determine which file is being recorded. It does this because rx creates the file and the tool doesn't know the name otherwise. Since the tool looks at an "*.raw" file (we could make it more specific) it is possibly for other files to appear last in the list. It's also possibly to get a file from a computer that has a different clock setting, and has what looks like a future time. When I tested these cases, things didn't work right.

@willcode

willcode commented May 7, 2023

Copy link
Copy Markdown
Contributor Author

Maybe we should just "do it right" and have the rx signal that it's recording/playing a certain file. Then the IQ tool doesn't need to infer the file name.

@willcode
willcode force-pushed the feature/iq-tool-filewatcher branch 2 times, most recently from 89b7a20 to 7f230c6 Compare May 9, 2023 12:38
@willcode
willcode marked this pull request as draft May 9, 2023 20:05
@willcode
willcode force-pushed the feature/iq-tool-filewatcher branch 2 times, most recently from f509c13 to 5454bbe Compare May 14, 2023 08:38
@willcode
willcode force-pushed the feature/iq-tool-filewatcher branch from 5454bbe to 6b235e7 Compare June 18, 2023 14:14
@argilo argilo added the cleanup label Jun 21, 2023
- Use QFileSystemWatcher instead of polling
- Sort by time instead of name
- Rec time is not dependent on dir contents
- Gray out more widgets while recording

Signed-off-by: Jeff Long <willcode4@gmail.com>
@willcode
willcode force-pushed the feature/iq-tool-filewatcher branch from 6b235e7 to 6b89d37 Compare July 25, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants