Merged
Conversation
tenntenn
force-pushed
the
fix-23-tool-directive
branch
3 times, most recently
from
147a7d1 to
9b237ff
Compare
tenntenn
force-pushed
the
fix-23-tool-directive
branch
from
9b237ff to
4f7d60e
Compare
tenntenn
commented
Mar 18, 2025
| go vet ./... | ||
| go vet -vettool=$(pwd)/tennvet ./... | ||
| go test -v -race ./... | ||
| - name: Checkout code |
Member
Author
There was a problem hiding this comment.
The go.mod specifies 1.23.7 as go directive but this PR chages for Go1.24 environment. Then the go.mod specifies 1.24.1 as toolchain directive.
Because tennvet checks whether use feature Go version build constraint, Install Go with toolchain directive version.
Arupaka1152
reviewed
Mar 19, 2025
pre_go124.go
Outdated
| // This function does nothing. | ||
| // Because go.mod does not have a tool directive until Go1.24. | ||
| func removeToolDirective(tb testing.TB) { | ||
| t.Helper() |
Collaborator
There was a problem hiding this comment.
Since the parameter is named tb, it would be appropriate to use tb.Helper() instead of t.Helper().
|
|
||
| "golang.org/x/tools/go/analysis/analysistest" | ||
|
|
||
| "github.com/tenntenn/golden" |
Collaborator
There was a problem hiding this comment.
I noticed that the golden module is directly imported in this file, but it's listed as an indirect dependency in the go.mod file. Is this intentional?
tenntenn
force-pushed
the
fix-23-tool-directive
branch
2 times, most recently
from
923f0f7 to
b338990
Compare
tenntenn
force-pushed
the
fix-23-tool-directive
branch
from
b338990 to
1845db6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
go mod tidyin Go1.24 and later.Why