DeleteEdge: remove tail from parent list of head vertex#34
Open
svrana wants to merge 1 commit intogoombaio:masterfrom
Open
DeleteEdge: remove tail from parent list of head vertex#34svrana wants to merge 1 commit intogoombaio:masterfrom
svrana wants to merge 1 commit intogoombaio:masterfrom
Conversation
Makes DeleteEdge the inverse of AddEdge.
|
Hi, i see this PR wait over 2 years to merge. Is this package still supported or not? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes DeleteEdge the inverse of AddEdge
Description
AddEdge updates the children and parents set of the head and tail vertex, while DeleteEdge only removes the edge from the children of the tail vertex. This makes it difficult to use DeleteEdge as it does not fully remove the edge from the dag. In order to implement a topological sort, I needed to first implement my own DeleteEdge which shouldn't be necessary.
Approach
Fix the glitch by updating the parent list of the headVertex.
I followed the existing code in DeleteEdge that searches the entire set before calling remove(), but this is redundant as OrderedSet will repeat the same operation afaict. I can adjust that if desired.