Skip to content

Adds proportionally spaced masters to upright source - #116

Merged
MariannaPaszkowska merged 93 commits into
mainfrom
wip-upright-proportional-spacing
Jun 3, 2026
Merged

Adds proportionally spaced masters to upright source#116
MariannaPaszkowska merged 93 commits into
mainfrom
wip-upright-proportional-spacing

Conversation

@kalapi

@kalapi kalapi commented May 12, 2026

Copy link
Copy Markdown
Collaborator

kalapi and others added 30 commits April 13, 2026 14:37
@MariannaPaszkowska

MariannaPaszkowska commented May 21, 2026

Copy link
Copy Markdown
Collaborator

I was reviewing this build: https://github.com/googlefonts/googlesans-code/actions/runs/25762954068 this link was shared by @kalapi via email.

@aaronbell

Copy link
Copy Markdown
Contributor

Hi @joanaranito @kalapi, I finally had a chance to complete my full review of the kern data. Sorry for the delay! I had to attend to other matters for the past days. All of these comments are using the latest source files, and I conducted the review in Glyphs.

TCH - /T/C too tight
BQU - /B/Q too tight
WQU - W/Q too tight
FAB - /F/A too tight
GUJA - /U/J too loose
blo - /b/l too tight (I think the left side of the /l is a little tight in general)
ebx - /b/x too tight (maybe the /x is a little tight in general? /x/a also tight)
ubt - /b/t too tight
geh - /g/e too tight (/g/o also tight)
gae - /g/a too tight (/g/o also tight)
ngp - /g/p too tight
gzg - g/z too tight (might be worth reviewing the /g RSB in general)
zgu - /z/g too tight
coyo - /o/y/o too tight on both sides of the /y
vqu - /y/q too tight
dan - /d/a too loose
Han - /H/a too loose
Ayn - /A/y & /A/w too tight (generally these diagonals are a bit tight next to caps)
Zyl - /Z/y & /Z/v too tight
Tö collision in ExBlack
fä / fö collision in ExBlack
Yä collision in ExBlack
ďä collision in ExBlack
l·l uneven spacing
ŀl extremely tight spacing
Þæt - /Þ/æ too loose
aľ: - /ľ/: too tight
ë™ Quite a few of the TM pairs with diacritics are too tight & collide in ExBlack
@i too tight (including all diacritic variants too) primarily in ExBlack

LMK if you have any questions.
f4g - /f/4 Maybe a little tight?

@joanaranito

Copy link
Copy Markdown
Collaborator

Thanks Aaron, we will review, make fixes, and get back to you soon

@joanaranito

Copy link
Copy Markdown
Collaborator

Just to keep the discussion in the issue up to date, @MariannaPaszkowska was reviewing the font on Figma, which was loading an older version on the font, even though the current version was installed :)

@kalapi

kalapi commented May 23, 2026

Copy link
Copy Markdown
Collaborator Author

Hi @aaronbell and @MariannaPaszkowska This is PR is ready for review. @joanaranito has made the changes you requested.

@joanaranito

joanaranito commented May 25, 2026

Copy link
Copy Markdown
Collaborator

Hi @MariannaPaszkowska and @aaronbell,

I'd forgotten to intepolate the middle masters, apologies for that. I've done so now, and pushed the fixes to the same branch. I've also removed 0 value kerning pairs from all masters and fixed some stray glyph-to-class kerning.

Since GS Code is 2000 UPM, I have also removed very small kerning pairs (between 5 and -5) from the middle masters, since they make almost no visible difference and end up weighing down the font. I've done this in a single commit, which can be reverted if you prefer to have these in the font.

@aaronbell

Copy link
Copy Markdown
Contributor

Thanks for the fixes! Most of the items I listed have been resolved. But a few could use a second look:

The ExBold is looking better. Light still uneven & tight
Screenshot 2026-05-26 at 8 36 13 AM
Screenshot 2026-05-26 at 8 37 10 AM

I still see quite a bit of unevenness in the /g. Is worth reviewing the SB & kern on it.
Screenshot 2026-05-26 at 8 36 38 AM

@joanaranito

Copy link
Copy Markdown
Collaborator

Hi Marianna and Aaron,

We've made fixes to the kerning issues reported, they are now ready for your review.

@MariannaPaszkowska
MariannaPaszkowska merged commit 74969c3 into main Jun 3, 2026
9 checks passed
@MariannaPaszkowska
MariannaPaszkowska deleted the wip-upright-proportional-spacing branch June 3, 2026 09:13
@MariannaPaszkowska

Copy link
Copy Markdown
Collaborator

Many thanks for your hard work on that PR! I reviewed the fonts again and I approve the changes.
Congratulations! @joanaranito @kalapi

@aaronbell

Copy link
Copy Markdown
Contributor

Thank you Kalapa and Joana!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

-ready for review ready for discussion/revision enhancement New feature or request type design

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants