Adds proportionally spaced masters to upright source - #116
Conversation
…/googlefonts/googlesans-code into wip-upright-proportional-spacing
|
I was reviewing this build: https://github.com/googlefonts/googlesans-code/actions/runs/25762954068 this link was shared by @kalapi via email. |
|
Hi @joanaranito @kalapi, I finally had a chance to complete my full review of the kern data. Sorry for the delay! I had to attend to other matters for the past days. All of these comments are using the latest source files, and I conducted the review in Glyphs. TCH - /T/C too tight LMK if you have any questions. |
|
Thanks Aaron, we will review, make fixes, and get back to you soon |
|
Just to keep the discussion in the issue up to date, @MariannaPaszkowska was reviewing the font on Figma, which was loading an older version on the font, even though the current version was installed :) |
|
Hi @aaronbell and @MariannaPaszkowska This is PR is ready for review. @joanaranito has made the changes you requested. |
|
Hi @MariannaPaszkowska and @aaronbell, I'd forgotten to intepolate the middle masters, apologies for that. I've done so now, and pushed the fixes to the same branch. I've also removed 0 value kerning pairs from all masters and fixed some stray glyph-to-class kerning. Since GS Code is 2000 UPM, I have also removed very small kerning pairs (between 5 and -5) from the middle masters, since they make almost no visible difference and end up weighing down the font. I've done this in a single commit, which can be reverted if you prefer to have these in the font. |
…l kerning pairs from middle masters
|
Hi Marianna and Aaron, We've made fixes to the kerning issues reported, they are now ready for your review. |
|
Many thanks for your hard work on that PR! I reviewed the fonts again and I approve the changes. |
|
Thank you Kalapa and Joana! |



Uh oh!
There was an error while loading. Please reload this page.