Skip to content

Conversation

@daniel-sanche
Copy link
Contributor

Rename Function to FunctionExpression, and add a warning that other changes in the API surface may come before GA

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: firestore Issues related to the googleapis/python-firestore API. labels Jan 13, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello @daniel-sanche, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on enhancing the clarity of the Firestore Pipelines API by renaming a key class to better reflect its purpose. Additionally, it introduces explicit warnings across the relevant modules to inform users about the preview status of the API and the possibility of future breaking changes, ensuring better expectation management for developers.

Highlights

  • API Renaming: The core Function class has been renamed to FunctionExpression for improved clarity and consistency within the API surface.
  • Preview API Warning: Warnings have been added to several Firestore Pipelines API files, indicating that the API is currently in preview and subject to potential breaking changes in future releases.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily renames Function to FunctionExpression across the Firestore pipeline-related files to better reflect its purpose. It also adds a 'Preview API' warning to the docstrings of these modules and classes. The renaming has been applied consistently. My review includes suggestions to improve code style consistency, specifically regarding indentation in the new warning docstrings and removing extra blank lines to adhere to PEP 257.

@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Jan 14, 2026
@daniel-sanche daniel-sanche marked this pull request as ready for review January 14, 2026 01:33
@daniel-sanche daniel-sanche requested review from a team as code owners January 14, 2026 01:33
@daniel-sanche daniel-sanche assigned bhshkh and unassigned rafikhan Jan 14, 2026
@daniel-sanche daniel-sanche merged commit 1e0ec96 into pipeline-preview-public Jan 14, 2026
6 checks passed
@daniel-sanche daniel-sanche deleted the rename_function branch January 14, 2026 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the googleapis/python-firestore API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants