-
Notifications
You must be signed in to change notification settings - Fork 83
chore(tests): re-enable pipeline system tests on kokoro #1153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: pipeline-preview-public
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @daniel-sanche, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on re-enabling and enhancing the pipeline system tests on Kokoro, alongside integrating full support for Python 3.14. A significant portion of the changes introduces new Firestore Pipeline API features, allowing for more complex and efficient data querying and transformation directly within the client libraries. These updates ensure compatibility with the latest Python versions and expand the functional capabilities of the Firestore client. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request re-enables pipeline system tests on Kokoro by removing the IS_KOKORO_TEST flag and its usage across the test suite. The changes are straightforward and correctly remove the conditional logic that was previously skipping these tests. My review includes a couple of suggestions to clean up unused imports in the database fixtures for both test_system.py and test_system_async.py, which became redundant after the test-skipping logic was removed. This will help improve code maintainability.
Kokoro tests for pipelines were previously disabled until the backend supports the feature. This branch will re-enable those tests, when the backend is ready