Skip to content

Conversation

@lqiu96
Copy link
Member

@lqiu96 lqiu96 commented Jan 21, 2026

No description provided.

@lqiu96 lqiu96 requested a review from jinseopkim0 January 21, 2026 19:35
@lqiu96 lqiu96 requested review from a team as code owners January 21, 2026 19:35
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/java-bigquery API. labels Jan 21, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @lqiu96, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a crucial integration test to verify the functionality of positional parameters with high-precision timestamp fields in BigQuery queries. This ensures the robustness and accuracy of timestamp handling within the client library. Concurrently, the existing test suite for high-precision timestamps has been refactored to enhance maintainability and improve test isolation, making the tests more reliable and easier to understand.

Highlights

  • New Integration Test for Positional Parameters: A new integration test, queryPositionalParameter_highPrecisionTimestamp, has been added to validate the correct handling of positional parameters when querying BigQuery tables with high-precision timestamp fields. This ensures the client library accurately processes timestamp values with picosecond precision.
  • Test Class Refactoring for Isolation and Readability: The ITHighPrecisionTimestamp test class has undergone refactoring. This includes changing class and method visibility from public to package-private, aligning with JUnit 5 best practices. Additionally, temporary table names are now dynamically generated using a new generateTempTableName(String prefix) helper method, improving test isolation and preventing naming conflicts across test runs.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds an integration test for using positional parameters with high-precision timestamp fields in BigQuery. It also includes several good refactorings, such as making test components package-private and improving the temporary table name generation to prevent collisions. My review includes suggestions to make the new test more robust by not relying on query result order and to improve readability by avoiding magic strings.

Copy link
Contributor

@jinseopkim0 jinseopkim0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the lint CI failures.

@lqiu96 lqiu96 requested a review from jinseopkim0 January 21, 2026 19:54
@lqiu96 lqiu96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 21, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 21, 2026
@lqiu96 lqiu96 merged commit 6b4081d into main Jan 21, 2026
25 of 26 checks passed
@lqiu96 lqiu96 deleted the positional-param-ITs branch January 21, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/java-bigquery API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants