chore: librarian update image pull request: 20260114T204442Z #15458

parthea · 2026-01-14T20:46:17Z

feat: update image to us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:51d42b9060365aa10d21e64a370b82bf1e07ed7f1e46062dcb3ad10632b0acc8

…prod/images-prod/python-librarian-generator@sha256:51d42b9060365aa10d21e64a370b82bf1e07ed7f1e46062dcb3ad10632b0acc8

gemini-code-assist · 2026-01-14T20:50:36Z

Summary of Changes

Hello @parthea, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on maintenance and modernization efforts across various Google Cloud client libraries. It updates the underlying librarian image, aligns mypy configurations with Python 3.14, and streamlines credential parameter passing in transport layers. These changes contribute to a more up-to-date and robust development environment for the client libraries.

Highlights

Librarian Image Update: The core librarian image used for generating client libraries has been updated to a new SHA256 hash, ensuring the use of the latest generator version.
Mypy Configuration and Python Version Alignment: Mypy configurations across numerous client libraries have been updated to target Python 3.14, and a new mypy-3.14 test target has been added to the CI script.
Credential Handling Refactoring: A significant refactoring has been applied to credential handling in many base.py transport files. The scopes_kwargs dictionary has been removed, and arguments are now passed directly to google.auth.load_credentials_from_file and google.auth.default for improved clarity and consistency.
Dependency Updates in BigQuery Storage: Minor dependency adjustments were made in the noxfile.py for the google-cloud-bigquery-storage package, specifically removing cachetools and cryptography from test dependencies.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files

Ignored by pattern: .github/workflows/** (1)
- .github/workflows/lint.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request updates the librarian generator image and applies the resulting generated code changes. The changes include a beneficial refactoring of credential handling across many services to use explicit keyword arguments, improving code clarity. Additionally, a new mypy test type has been added to the CI script.

However, a critical issue has been introduced in all updated mypy.ini files, where python_version is set to 3.14, which is not a valid Python version. This will likely cause issues with static type checking and should be corrected to a valid version (e.g., 3.12). I've added a specific comment on one of the files highlighting this.

gemini-code-assist · 2026-01-14T20:54:22Z

packages/google-ads-admanager/mypy.ini

@@ -1,3 +1,3 @@
 [mypy]
-python_version = 3.7
+python_version = 3.14


The python version 3.14 is not a valid Python version. Mypy expects a version in X.Y format (e.g., 3.12). This will cause mypy to behave unexpectedly or fail. This issue is present in all modified mypy.ini files and should be corrected to a valid Python version.

python_version = 3.12

gemini-code-assist · 2026-01-14T20:54:22Z

packages/google-ads-datamanager/mypy.ini

@@ -1,3 +1,3 @@
 [mypy]
-python_version = 3.7
+python_version = 3.14
