Skip to content

Conversation

@daniel-sanche
Copy link
Collaborator

Some google3 tests were failing due to timeouts. It seems like there were some tests that preformed up to 10 retries, with exponential backoff between each one

This PR mocks out sleep, so these tests will complete ~ instantly, rather than > 10 mins

@daniel-sanche daniel-sanche requested review from a team as code owners January 16, 2026 03:43
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @daniel-sanche, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses test suite performance issues by mocking time.sleep in specific test cases. Previously, these tests could take over ten minutes to complete due to multiple retries with exponential backoff, leading to timeouts. By mocking the sleep function, the tests now execute almost instantly, improving the reliability and speed of the test pipeline.

Highlights

  • Test Performance Improvement: Introduced time.sleep mocking in several tests to prevent timeouts caused by exponential backoff retries, significantly reducing test execution time from potentially over 10 minutes to near instant completion.
  • Specific Test Cases Addressed: Applied time.sleep mocks to test_ping_failure_custom_retry, test_get_too_many_requests_retryable_error_failure, and test_get_universe_domain_retryable_error_failure within tests/compute_engine/test__metadata.py.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses test timeouts by mocking time.sleep in several tests that involve retry logic with exponential backoff. The changes are correct and will effectively speed up the test suite. I've added a few minor suggestions to improve code clarity by marking unused mock arguments, which is a common Python convention.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@daniel-sanche daniel-sanche changed the title chore(tests): add mocks to sleeps chore(tests): add sleep mocks Jan 16, 2026
@daniel-sanche daniel-sanche merged commit db17a64 into main Jan 16, 2026
23 of 24 checks passed
@daniel-sanche daniel-sanche deleted the fix_test_sleep branch January 16, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants