Skip to content

Conversation

@aeitzman
Copy link
Contributor

No description provided.

@aeitzman aeitzman requested review from a team as code owners August 19, 2024 18:04
@aeitzman aeitzman requested a review from engelke August 19, 2024 18:04
@snippet-bot
Copy link

snippet-bot bot commented Aug 19, 2024

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Aug 19, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Aug 19, 2024
lsirac
lsirac previously approved these changes Aug 20, 2024
sai-sunder-s
sai-sunder-s previously approved these changes Sep 5, 2024
@aeitzman aeitzman added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 5, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 5, 2024
@clundin25 clundin25 removed their assignment Aug 14, 2025
return self._region


def authenticate_with_aws_supplier(project_id="your-google-cloud-project-id", aws_region="your_aws_region", audience="your_federation_audience"):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

samples/cloud-client/snippets/snippets_test.py needs to be updated to call authenticate_with_aws_supplier to add this to the existing samples presubmit tests

@parthea
Copy link
Contributor

parthea commented Jan 5, 2026

Switching to draft while review comments are being addressed

@parthea parthea marked this pull request as draft January 5, 2026 17:53
@chalmerlowe chalmerlowe assigned chalmerlowe and unassigned lsirac Jan 14, 2026
@chalmerlowe chalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 14, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 14, 2026
@googleapis googleapis deleted a comment from Gotradepal Jan 14, 2026
@googleapis googleapis deleted a comment from Gotradepal Jan 14, 2026
@chalmerlowe chalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 16, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 16, 2026
@chalmerlowe
Copy link
Contributor

@aeitzman I appreciate you submitting this PR and I understand that it has been a long time.
If you are interested in having this merged and your schedule allows, Google requires a CLA.

I will hold off on moving forward until Tuesday, Jan 20th @ Noon (EST). I know this is a short turn around, my apologies. At that time, we will close out this PR so that we can prep to migrate this repo into the google-cloud-auth mono-repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants