-
Notifications
You must be signed in to change notification settings - Fork 346
docs: Improve AWS supplier samples #1586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
| return self._region | ||
|
|
||
|
|
||
| def authenticate_with_aws_supplier(project_id="your-google-cloud-project-id", aws_region="your_aws_region", audience="your_federation_audience"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
samples/cloud-client/snippets/snippets_test.py needs to be updated to call authenticate_with_aws_supplier to add this to the existing samples presubmit tests
|
Switching to draft while review comments are being addressed |
|
@aeitzman I appreciate you submitting this PR and I understand that it has been a long time. I will hold off on moving forward until Tuesday, Jan 20th @ Noon (EST). I know this is a short turn around, my apologies. At that time, we will close out this PR so that we can prep to migrate this repo into the |
No description provided.