Add a new utility which will register an autoloader that will load either 'Current' (for a user specified version) or 'Latest' as a namespace path#1120
Open
DeveloperRob wants to merge 1 commit intogoogleads:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
…ther 'Current' (for a user specified version) or 'Latest' as a namespace path
7175b89 to
faa4403
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will fix #1065
Add a new utility which can register an autoloader that allows user code to specify
\Google\Ads\GoogleAds\Latestto always use the latest API version, orGoogle\Ads\GoogleAds\Currentto always use a specified version (allowing upgrades to newer versions by updating a single location in the code).I would welcome any feedback or suggestions on improvements / changes. I am also aware that users using
setGoogleAdsAutoloaderLatestVersionare running the risk of changing API version without reviewing the migration guide, however as each new release is a major version increase they should be manually updating theircomposer.json, and the original request seemed to want to be able to always use the latest version.Finally, I have not added tests yet, as I would like to see if there is any feedback that requires changes first (although I have manually tested the code). I am happy to provide tests once the main code is in an acceptable state.