Fix OneShotReassociationVisitor::HandleNeg() crash found by fuzzing.#4041
Merged
copybara-service[bot] merged 1 commit intomainfrom Apr 2, 2026
Merged
Fix OneShotReassociationVisitor::HandleNeg() crash found by fuzzing.#4041copybara-service[bot] merged 1 commit intomainfrom
OneShotReassociationVisitor::HandleNeg() crash found by fuzzing.#4041copybara-service[bot] merged 1 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
test_893684576
branch
from
9c531a7 to
1573155
Compare
The crash happens by dereferencing the iterator of an empty `all_elements()` range. This occurs when elements in an associative addition cancel out (e.g., `x + (-x)`), leaving the `AssociativeElements` with no variables or constants. PiperOrigin-RevId: 893724214
copybara-service
bot
force-pushed
the
test_893684576
branch
from
1573155 to
f452e8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
OneShotReassociationVisitor::HandleNeg()crash found by fuzzing.The crash happens by dereferencing the iterator of an empty
all_elements()range. This occurs when elements in an associative addition cancel out (e.g.,x + (-x)), leaving theAssociativeElementswith no variables or constants.