Refactor Function::is_test_utility to examine its attributes instead of mutable state for the "test utility" flag.#4006
Draft
copybara-service[bot] wants to merge 1 commit intomainfrom
Draft
Refactor Function::is_test_utility to examine its attributes instead of mutable state for the "test utility" flag.#4006copybara-service[bot] wants to merge 1 commit intomainfrom
Function::is_test_utility to examine its attributes instead of mutable state for the "test utility" flag.#4006copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
…d of mutable state for the "test utility" flag. This removes the `is_test_utility_` mutable field and `set_test_utility()` from the `Function` AST node. Instead, `Function::is_test_utility()` is evaluated dynamically by querying the node's attributes. The parser also now copies the `#[cfg(test)]` attribute from a `proc` down to its component functions to preserve AST-based test utility identification without relying on mutable state. PiperOrigin-RevId: 890001378
copybara-service
bot
force-pushed
the
test_890001378
branch
from
ecf1e23 to
3386d0f
Compare
copybara-service
bot
changed the title
Function::is_test_utility to examine its attributes instead of mutable state for the "test utility" flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor
Function::is_test_utilityto examine its attributes instead of mutable state for the "test utility" flag.This removes the
is_test_utility_mutable field andset_test_utility()from theFunctionAST node.Instead,
Function::is_test_utility()is evaluated dynamically by querying the node's attributes.The parser also now copies the
#[cfg(test)]attribute from aprocdown to its component functions to preserve AST-based test utility identification without relying on mutable state.