[opt] Use a structural fingerprint to break ties in ReassociationPass#4000
Draft
copybara-service[bot] wants to merge 1 commit intomainfrom
Draft
[opt] Use a structural fingerprint to break ties in ReassociationPass#4000copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
Introduces a new lazy analysis, NodeFingerprintAnalysis, which computes a structural hash for each node in a function. This fingerprint is stable across changes to node IDs or names, as long as the underlying expression structure remains the same. The ReassociationPass is updated to use this fingerprint in its sorting comparison for associative elements. By including the fingerprint in the sort order, the pass can more consistently break ties between nodes it can't otherwise distinguish except by name or ID, helping to prevent infinite loops where the pass oscillates between two equivalent IR forms. PiperOrigin-RevId: 888868233
copybara-service
bot
force-pushed
the
test_888868233
branch
from
28c9f8b to
ed3b9a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[opt] Use a structural fingerprint to break ties in ReassociationPass
Introduces a new lazy analysis, NodeFingerprintAnalysis, which computes a structural hash for each node in a function. This fingerprint is stable across changes to node IDs or names, as long as the underlying expression structure remains the same.
The ReassociationPass is updated to use this fingerprint in its sorting comparison for associative elements. By including the fingerprint in the sort order, the pass can more consistently break ties between nodes it can't otherwise distinguish except by name or ID, helping to prevent infinite loops where the pass oscillates between two equivalent IR forms.