Add IR conversion feedback to the DSLX interpreter#3882
Add IR conversion feedback to the DSLX interpreter#3882magancarz wants to merge 1 commit intogoogle:mainfrom
Conversation
|
FYI @richmckeever |
|
should we also add this to typecheck_main? |
|
This also need to be rebased. |
26b3fee to
254cd57
Compare
|
I've rebased changes on the latest main.
Sounds reasonable. @richmckeever what do you think? |
|
There seems to be no way to configure IR convert options through Rather than overloading xls_dslx_test in this way, what do we think about a separate |
|
@mikex-oss The intent behind IR conversion check when running DSLX tests was to prevent situations where the user would spend time on developing DSLX code that wouldn't be possible to convert to IR, which is an issue that would surface only when the user would run a xls_dslx_ir target. Moving this task to another target would make these changes unnecessary. @richmckeever What do you think? |
This PR adds an IR conversion test to the DSLX interpreter enabled by
lower_to_irflag which is set by default. It performs the IR conversion check on every non-parametric proc or function and returns error if any fails. Tests can also be included in the check by addingconvert_testsflag.