Skip to content

Automated rollback of commit 0fb55101694edfc6aadcd411d7c2c50b3871d5b1. #3853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Draft

Automated rollback of commit 0fb55101694edfc6aadcd411d7c2c50b3871d5b1. #3853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion xls/dslx/ir_convert/convert_options.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ struct ConvertOptions {

// Should we generate proc-scoped channels without global channels as an
// intermediate step? See https://github.com/google/xls/issues/2078
bool lower_to_proc_scoped_channels = false;
bool lower_to_proc_scoped_channels = true;

// Force every DSLX function to use the implicit-token calling convention,
// regardless of what type inference determined.
Expand Down
2 changes: 1 addition & 1 deletion xls/dslx/ir_convert/ir_converter_main.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ absl::Status RealMain(absl::Span<const std::string_view> paths) {
bool lower_to_proc_scoped_channels =
ir_converter_options.has_lower_to_proc_scoped_channels()
? ir_converter_options.lower_to_proc_scoped_channels()
: false;
: true;
bool force_implicit_token_calling_convention =
ir_converter_options.force_implicit_token_calling_convention();
bool emit_trace = ir_converter_options.emit_trace();
Expand Down
Loading