Skip to content

docs: introduce code review guidelines - #7021

Merged
tarasmadan merged 1 commit into
google:masterfrom
tarasmadan:use-repo-review-rules
Apr 28, 2026
Merged

docs: introduce code review guidelines#7021
tarasmadan merged 1 commit into
google:masterfrom
tarasmadan:use-repo-review-rules

Conversation

@tarasmadan

@tarasmadan tarasmadan commented Mar 27, 2026

Copy link
Copy Markdown
Collaborator

Updates #6891

@tarasmadan
tarasmadan marked this pull request as ready for review March 27, 2026 16:29
@tarasmadan
tarasmadan force-pushed the use-repo-review-rules branch from b2ecb85 to c980500 Compare March 27, 2026 16:33
@tarasmadan
tarasmadan enabled auto-merge March 27, 2026 16:33
Comment thread skills/DVYUKOV.md Outdated
@tarasmadan
tarasmadan force-pushed the use-repo-review-rules branch from c980500 to e74c8bf Compare March 27, 2026 16:50

@dvyukov dvyukov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you reviewed the guidelines manually?

Comment thread skills/DVYUKOV.md Outdated
@tarasmadan
tarasmadan force-pushed the use-repo-review-rules branch from e74c8bf to dedc6a5 Compare April 7, 2026 10:39
@tarasmadan

Copy link
Copy Markdown
Collaborator Author

@gemini-cli remove the TIP section at the end

@syzbot-noreply

Copy link
Copy Markdown

🤖 Hi @tarasmadan, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

@syzbot-noreply

syzbot-noreply commented Apr 7, 2026

Copy link
Copy Markdown

🤖 AI Assistant: Plan of Action

I have analyzed the request and propose the following plan. This plan will not be executed until it is approved by a maintainer.

Resource Estimate:

  • Estimated Tool Calls: ~2
  • Files to Modify: 1

Proposed Steps:

  • Step 1: Remove the > [!TIP] section at the end of skills/DVYUKOV.md.

Please review this plan. To approve, comment @gemini-cli /approve on this issue. To make changes, comment changes needed.

@tarasmadan

Copy link
Copy Markdown
Collaborator Author

Have you reviewed the guidelines manually?

Yes. The first version was too long and we compressed it with @ramosian-glider.
Last lines are coming from #7019 and the border between these two PRs was quite blurred for me. Thanks for highlighting.

@tarasmadan

Copy link
Copy Markdown
Collaborator Author

@gemini-cli /approve

@syzbot-noreply

Copy link
Copy Markdown

🤖 Hi @tarasmadan, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

@syzbot-noreply

Copy link
Copy Markdown

🤖 I'm sorry @tarasmadan, but I was unable to process your request. Please see the logs for more details.

@tarasmadan
tarasmadan force-pushed the use-repo-review-rules branch 3 times, most recently from a027cfd to d390e8f Compare April 27, 2026 09:46
@tarasmadan

Copy link
Copy Markdown
Collaborator Author

ptal

@codecov

codecov Bot commented Apr 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.6%. Comparing base (15d8aa1) to head (fc64fac).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

see 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread docs/review_guidelines.md
Comment thread docs/review_guidelines.md
Comment thread skills/DVYUKOV.md Outdated
Comment thread GEMINI.md Outdated
Comment thread docs/review_guidelines.md
Comment thread skills/DVYUKOV.md Outdated
Comment thread skills/DVYUKOV.md Outdated
Comment thread skills/DVYUKOV.md Outdated
Comment thread docs/review_guidelines.md
Comment thread docs/review_guidelines.md
Comment thread skills/DVYUKOV.md Outdated
Comment thread skills/DVYUKOV.md Outdated
@tarasmadan
tarasmadan force-pushed the use-repo-review-rules branch from d390e8f to 8478bb0 Compare April 28, 2026 12:15
@tarasmadan tarasmadan changed the title .github/workflows: use repo-specific recommendations for code review docs: introduce code review guidelines Apr 28, 2026
@tarasmadan
tarasmadan added this pull request to the merge queue Apr 28, 2026
Merged via the queue into google:master with commit 051dd8e Apr 28, 2026
19 checks passed
@tarasmadan
tarasmadan deleted the use-repo-review-rules branch April 28, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants