fix: prevent open redirect via redirect/errorRedirect in OAuth connect flow#12403
Open
l3tchupkt wants to merge 1 commit intogoogle:developfrom
Open
fix: prevent open redirect via redirect/errorRedirect in OAuth connect flow#12403l3tchupkt wants to merge 1 commit intogoogle:developfrom
l3tchupkt wants to merge 1 commit intogoogle:developfrom
Conversation
Properly validate redirect host against site host. Reported-by: LAKSHMIKANTHAN K (letchupkt)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Properly validate redirect host against site host.
Reported-by: LAKSHMIKANTHAN K (letchupkt)
Summary
Addresses issue:
errorRedirectandredirectparametersThis PR resolves an open redirect issue where user-controlled redirect parameters were accepted without enforcing same-origin validation. This could allow redirection to external domains (e.g.,
accounts.google.com) after OAuth error handling.Relevant technical choices
redirectanderrorRedirectparameters inhandle_connect()wp_parse_url()to extract and compare redirect host against the site host (home_url())PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist