Skip to content

Refactor setup_services + get_service methods.#12362

Open
abdelmalekkkkk wants to merge 4 commits intodevelopfrom
hack/improve-google-services-typing
Open

Refactor setup_services + get_service methods.#12362
abdelmalekkkkk wants to merge 4 commits intodevelopfrom
hack/improve-google-services-typing

Conversation

@abdelmalekkkkk
Copy link
Copy Markdown
Collaborator

Summary

Addresses issue:

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@abdelmalekkkkk abdelmalekkkkk force-pushed the infrastructure/11834-php-stan-3 branch 2 times, most recently from 00b3635 to b46cb5c Compare March 25, 2026 12:39
Base automatically changed from infrastructure/11834-php-stan-3 to develop March 25, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant