Skip to content

Update packages with React 17 and tests passing.#12315

Open
tofumatt wants to merge 28 commits intodevelopfrom
typescript-fewer-package-changes
Open

Update packages with React 17 and tests passing.#12315
tofumatt wants to merge 28 commits intodevelopfrom
typescript-fewer-package-changes

Conversation

@tofumatt
Copy link
Copy Markdown
Collaborator

Summary

Addresses issue:

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 21, 2026

🤖 This comment is automatically updated by CI workflows. Each section is managed independently.

📚 Storybook for 2291758:

📦 Build files for 2291758:

🎭 Playwright reports for 2291758:

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 21, 2026

Size Change: -35.1 kB (-1.52%)

Total Size: 2.27 MB

📦 View Changed
Filename Size Change
dist/assets/js/googlesitekit-entity-dashboard-********************.js 71.4 kB -1.4 kB (-1.92%)
dist/assets/js/googlesitekit-key-metrics-setup-********************.js 52.3 kB -1.07 kB (-2.01%)
dist/assets/js/googlesitekit-modules-ads-********************.js 47.5 kB -1.42 kB (-2.89%)
dist/assets/js/googlesitekit-modules-adsense-********************.js 135 kB -3.26 kB (-2.36%)
dist/assets/js/googlesitekit-modules-analytics-4-********************.js 186 kB -5.51 kB (-2.89%)
dist/assets/js/googlesitekit-modules-search-console-********************.js 65 kB -2.19 kB (-3.26%)
dist/assets/js/googlesitekit-notifications-********************.js 67.3 kB -1.21 kB (-1.77%)
dist/assets/js/googlesitekit-settings-********************.js 133 kB -2.22 kB (-1.64%)
dist/assets/js/googlesitekit-user-input-********************.js 50.3 kB -1.05 kB (-2.04%)
dist/assets/js/googlesitekit-vendor-********************.js 315 kB -12.8 kB (-3.9%)
dist/assets/js/googlesitekit-widgets-********************.js 103 kB -1.15 kB (-1.1%)
dist/assets/js/googlesitekit-wp-dashboard-********************.js 60.3 kB -1.81 kB (-2.91%)
ℹ️ View Unchanged
Filename Size Change
dist/assets/blocks/reader-revenue-manager/block-editor-plugin/editor-styles.css 124 B 0 B
dist/assets/blocks/reader-revenue-manager/block-editor-plugin/editor-styles.js 0 B 0 B 🆕
dist/assets/blocks/reader-revenue-manager/block-editor-plugin/index.js 42.7 kB -5 B (-0.01%)
dist/assets/blocks/reader-revenue-manager/common/editor-styles.css 307 B 0 B
dist/assets/blocks/reader-revenue-manager/common/editor-styles.js 0 B 0 B 🆕
dist/assets/blocks/reader-revenue-manager/contribute-with-google/index.js 5.81 kB -72 B (-1.22%)
dist/assets/blocks/reader-revenue-manager/contribute-with-google/non-site-kit-user.js 5 kB -66 B (-1.3%)
dist/assets/blocks/reader-revenue-manager/subscribe-with-google/index.js 5.81 kB -70 B (-1.19%)
dist/assets/blocks/reader-revenue-manager/subscribe-with-google/non-site-kit-user.js 5 kB -67 B (-1.32%)
dist/assets/blocks/sign-in-with-google/editor-styles.css 84 B 0 B
dist/assets/blocks/sign-in-with-google/editor-styles.js 0 B 0 B 🆕
dist/assets/blocks/sign-in-with-google/index.js 18.5 kB -69 B (-0.37%)
dist/assets/css/googlesitekit-admin-css-********************.min.css 67.1 kB -2 B (0%)
dist/assets/css/googlesitekit-adminbar-css-********************.min.css 12.2 kB -36 B (-0.29%)
dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 851 B +5 B (+0.59%)
dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 8.88 kB -9 B (-0.1%)
dist/assets/js/146-********************.js 960 B -3 B (-0.31%)
dist/assets/js/201-********************.js 2.85 kB -3 B (-0.11%)
dist/assets/js/314-********************.js 100 kB -3 B (0%)
dist/assets/js/315-********************.js 3.08 kB -2 B (-0.06%)
dist/assets/js/379-********************.js 3.7 kB -3 B (-0.08%)
dist/assets/js/590-********************.js 1.88 kB -3 B (-0.16%)
dist/assets/js/640-********************.js 2.35 kB -3 B (-0.13%)
dist/assets/js/909-********************.js 1.01 kB -2 B (-0.2%)
dist/assets/js/analytics-advanced-tracking-********************.js 404 B -71 B (-14.95%) 👏
dist/assets/js/googlesitekit-activation-********************.js 24.6 kB -453 B (-1.81%)
dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 58.6 kB -987 B (-1.66%)
dist/assets/js/googlesitekit-admin-pointers-tracking-********************.js 5.36 kB +13 B (+0.24%)
dist/assets/js/googlesitekit-adminbar-********************.js 35.3 kB -762 B (-2.11%)
dist/assets/js/googlesitekit-api-********************.js 8.01 kB +20 B (+0.25%)
dist/assets/js/googlesitekit-block-tracking-********************.js 5.55 kB -4 B (-0.07%)
dist/assets/js/googlesitekit-components-********************.js 5.79 kB -31 B (-0.53%)
dist/assets/js/googlesitekit-consent-mode-********************.js 25.6 kB +101 B (+0.4%)
dist/assets/js/googlesitekit-data-********************.js 1.73 kB -6 B (-0.35%)
dist/assets/js/googlesitekit-datastore-forms-********************.js 7.04 kB +28 B (+0.4%)
dist/assets/js/googlesitekit-datastore-location-********************.js 1.52 kB +9 B (+0.6%)
dist/assets/js/googlesitekit-datastore-site-********************.js 18.3 kB -133 B (-0.72%)
dist/assets/js/googlesitekit-datastore-ui-********************.js 7.16 kB -7 B (-0.1%)
dist/assets/js/googlesitekit-datastore-user-********************.js 22.9 kB -119 B (-0.52%)
dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js 1.23 kB -50 B (-3.92%)
dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js 590 B -65 B (-9.92%) 👏
dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js 1.22 kB -52 B (-4.1%)
dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js 1.22 kB -47 B (-3.72%)
dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js 1.25 kB -49 B (-3.78%)
dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js 1.29 kB -47 B (-3.51%)
dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js 918 B -72 B (-7.27%)
dist/assets/js/googlesitekit-events-provider-wpforms-********************.js 1.25 kB -45 B (-3.48%)
dist/assets/js/googlesitekit-i18n-********************.js 6.1 kB -57 B (-0.93%)
dist/assets/js/googlesitekit-main-dashboard-********************.js 148 kB -921 B (-0.62%)
dist/assets/js/googlesitekit-metric-selection-********************.js 57.7 kB -205 B (-0.35%)
dist/assets/js/googlesitekit-modules-********************.js 25.9 kB -422 B (-1.6%)
dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 23.2 kB -390 B (-1.66%)
dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js 52.3 kB -477 B (-0.9%)
dist/assets/js/googlesitekit-modules-sign-in-with-google-********************.js 33.9 kB -806 B (-2.33%)
dist/assets/js/googlesitekit-modules-tagmanager-********************.js 29.8 kB -615 B (-2.02%)
dist/assets/js/googlesitekit-polyfills-********************.js 228 B -2 B (-0.87%)
dist/assets/js/googlesitekit-splash-********************.js 77.8 kB -772 B (-0.98%)
dist/assets/js/runtime-********************.js 1.86 kB -62 B (-3.22%)

compressed-size-action

@tofumatt
Copy link
Copy Markdown
Collaborator Author

Screenshot 2026-03-24 at 23 06 35

It seems the remaining test failures are largely around unexpected calls to this Analytics settings API endpoint.

@tofumatt
Copy link
Copy Markdown
Collaborator Author

I've resolved most of the test failures by mocking calls to Analytics settings, but a few give the error that fetch isn't defined, which is quite odd:

Screenshot 2026-03-25 at 14 01 16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants