Factor out common types that don't depend on the exact schema into schema-dts-lib#213
Merged
Eyas merged 1 commit intogoogle:mainfrom Mar 22, 2026
Merged
Factor out common types that don't depend on the exact schema into schema-dts-lib#213Eyas merged 1 commit intogoogle:mainfrom
Eyas merged 1 commit intogoogle:mainfrom
Conversation
…hema-dts-lib. This will be a breaking change for schema-dts-gen since the output of the generator will no longer be self contained, and will start referencing schema-dts-lib which needs to be imported by the user. schema-dts itself is updated to start importing the library, so this is self contained for it. We can't move WithContext, Graph, or SchemaValue out of our helper types though: - WithContext and Graph define the context specifically as "https://schema.org" which is not true for all schemas - SchemaValue depends on Role<> when Role is available/emitted
Collaborator
Author
|
@cochinescu this is basically what I have in mind. The new merging utils would go here as well. WDYT? |
Contributor
|
Yes, keeping Once #213 lands, I can update #210 to move |
cochinescu
added a commit
to cochinescu/schema-dts
that referenced
this pull request
Mar 23, 2026
Switch helper_types.ts back to SyntaxKind.TypeKeyword to match google#213. Also run npm run fix:prettier to apply the requested TS/MD formatting updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be a breaking change for schema-dts-gen since the output of the generator will no longer be self contained, and will start referencing schema-dts-lib which needs to be imported by the user.
schema-dts itself is updated to start importing the library, so this is self contained for it.
We can't move WithContext, Graph, or SchemaValue out of our helper types though: