Conversation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
m4tx
commented
Apr 3, 2026
Comment on lines
+81
to
+86
| old_handover = 'EntryPointInfo {\n pc: 0x6000_0000,\n args: Default::default(),\n }' | ||
| new_handover = 'EntryPointInfo {\n pc: 0x6000_0000,\n args: [0x4000_0000, 0, 0, 0, 0, 0, 0, 0],\n }' | ||
| if old_handover in content: | ||
| content = content.replace(old_handover, new_handover) | ||
| with open(rfa_platform_file, "w") as f: | ||
| f.write(content) |
Collaborator
Author
There was a problem hiding this comment.
I'm not very happy about this. @qwandor do you have any better idea on how to pass the DT from RF-A to RITM?
One option would be to hardcode the address in RITM itself, but it doesn't sound much nicer than patching RF-A...
This adds another integration test that primarily tests whether the PSCI CPU_SUSPEND call works correctly. This is somewhat tricky to do under QEMU, as neither its default firmware nor Trusted Firmware-A supports suspending CPUs. Therefore, the test script downloads and builds both Trusted Firmware-A and Rusted Firmware-A, and then runs the payload. To avoid pulling a bootloader on top of it, a qemu_bl33 platform config has been added so that ritm can now run as the bl33 payload in QEMU. Because TF-A/RF-A seem to leave EL1 system registers in non-reset state (just like any other firmware could), this also adds some code to reset the registers necessary to boot the test payload or the Linux kernel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds another integration test that primarily tests whether the PSCI CPU_SUSPEND call works correctly. This is somewhat tricky to do under QEMU, as neither its default firmware nor Trusted Firmware-A supports suspending CPUs.
Therefore, the test script downloads and builds both Trusted Firmware-A and Rusted Firmware-A, and then runs the payload. To avoid pulling a bootloader on top of it, a qemu_bl33 platform config has been added so that ritm can now run as the bl33 payload in QEMU.
Because TF-A/RF-A seem to leave EL1 system registers in non-reset state (just like any other firmware could), this also adds some code to reset the registers necessary to boot the test payload or the Linux kernel.