Additional logging for corner radii in SF and ViewRootImpl#5359
Open
surbhi-kadam wants to merge 1 commit intomainfrom
Open
Additional logging for corner radii in SF and ViewRootImpl#5359surbhi-kadam wants to merge 1 commit intomainfrom
surbhi-kadam wants to merge 1 commit intomainfrom
Conversation
…radii/client_drawn_radii_bounds to ViewRootImpl
🎨 Perfetto UI Builds
|
PriyankaSPX
approved these changes
Apr 1, 2026
rukkal
approved these changes
Apr 2, 2026
| optional CornerRadiiProto effective_radii = 67; | ||
|
|
||
| // Reported corner radii of the layer. | ||
| optional CornerRadiiProto reported_radii = 68; |
Contributor
There was a problem hiding this comment.
any chance that "requested_radii" would be more consistent with the other field names? Not sure, just sanity checking. Iirc we usually talk about "requested" and "computed" properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add reported_radii/disable_client_drawn_radii to SF Layer and corner_radii/client_drawn_radii_bounds to ViewRootImpl
Bug: 496202000