Open
Conversation
🎨 Perfetto UI Builds
|
stevegolton
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node graph serialization in Data Explorer previously required every node type to manually include connection IDs in its
serializeState()(e.g.leftNodeId,primaryInputId,unionNodes) and a correspondingdeserializeConnectionshook to restore them. This was error-prone and meant adding a new node type required remembering to handle connections in multiple places.Connections are now captured automatically at the graph level in
serializeNode()and restored generically indeserializeState(). NodeserializeState()methods only need to handle their own configuration data.Backward compatibility with old saved graphs (where connection IDs lived inside node state) is handled by a single declarative lookup table in
legacy_connections.ts, keeping it out ofcore_nodes.tsentirely.