Skip to content

de: Simplify serialization#5346

Open
aMayzner wants to merge 1 commit intomainfrom
dev/mayzner/simple-serialization
Open

de: Simplify serialization#5346
aMayzner wants to merge 1 commit intomainfrom
dev/mayzner/simple-serialization

Conversation

@aMayzner
Copy link
Copy Markdown
Member

Node graph serialization in Data Explorer previously required every node type to manually include connection IDs in its serializeState() (e.g. leftNodeId, primaryInputId, unionNodes) and a corresponding deserializeConnections hook to restore them. This was error-prone and meant adding a new node type required remembering to handle connections in multiple places.

Connections are now captured automatically at the graph level in serializeNode() and restored generically in deserializeState(). Node serializeState() methods only need to handle their own configuration data.

Backward compatibility with old saved graphs (where connection IDs lived inside node state) is handled by a single declarative lookup table in legacy_connections.ts, keeping it out of core_nodes.ts entirely.

@aMayzner aMayzner requested a review from stevegolton March 30, 2026 15:18
@github-actions
Copy link
Copy Markdown

🎨 Perfetto UI Builds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants