[DNS] perfetto: add a new flag for "stable incremental state"#5288
Draft
LalitMaganti wants to merge 1 commit intomainfrom
Draft
[DNS] perfetto: add a new flag for "stable incremental state"#5288LalitMaganti wants to merge 1 commit intomainfrom
LalitMaganti wants to merge 1 commit intomainfrom
Conversation
This CL adds a new flag and associated parsing code for marking incremental state as "stable". By stable, we mean that for a given piece of interned data you *never* define the same incremental scoped id with a different value anywhere else in the trace. This property is necessary for us to continue allowing the packet through the central proto reader code instead of just being dropped. The existing behavior is unchanged and works the same as it does today.
🎨 Perfetto UI Builds
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This CL adds a new flag and associated parsing code for marking
incremental state as "stable". By stable, we mean that for a given piece
of interned data you never define the same incremental scoped id with
a different value anywhere else in the trace.
This property is necessary for us to continue allowing the packet
through the central proto reader code instead of just being dropped. The
existing behavior is unchanged and works the same as it does today.