fix(seg layer): Save anchor segment in JSON state as string not BigInt if defined#916
Open
seankmartin wants to merge 3 commits intogoogle:masterfrom
Open
fix(seg layer): Save anchor segment in JSON state as string not BigInt if defined#916seankmartin wants to merge 3 commits intogoogle:masterfrom
seankmartin wants to merge 3 commits intogoogle:masterfrom
Conversation
chrisj
reviewed
Mar 23, 2026
Contributor
chrisj
left a comment
There was a problem hiding this comment.
I could go either way for adding the protection but since adding it would reduce the chance of a user error, it seems like the right choice.
Contributor
Author
Cheers Chris, added it in so! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #897
The issue was that the
anchorSegmentID in segmentation layers was being saved into the JSON state directly as a big int if it was defined, instead of being saved as a string like other segmentation IDs. This changes theanchorSegmentto be saved as string if defined.This bug did not affect all of the application, as many parts of the application use a
bigintToStringJsonReplacerwhen callingJSON.stringifyon the JSON state. However, the state editor does not use this replacer pattern nor does the screenshot actions insrc/python_integration/screenshot.ts. I have added thebigintToStringJsonReplacercall to the screenshot action to be on the safe side there. But I'm unsure if it should be added to the JSON state editor. Adding this protection to the editor could possibly help hide a case where a big int value is incorrectly stored in the state and potentially incorrectly parsed from the state.