feat: update invlerp and transferFunction heuristic for emitIntensity#860
Closed
seankmartin wants to merge 1 commit intogoogle:masterfrom
Closed
feat: update invlerp and transferFunction heuristic for emitIntensity#860seankmartin wants to merge 1 commit intogoogle:masterfrom
seankmartin wants to merge 1 commit intogoogle:masterfrom
Conversation
Contributor
Author
|
Closing to reduce noise. Ideal fix is to improve blending and avoid these kind of shaders needing to be written. If it comes to it, within the shader itself the user can take a min/max over channels and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if you have more than one invlerp or transfer function UI control and use max projection volume rendering, if no
emitIntensityis manually called in the user defined shader with neuroglancer, neuroglancer will use the value of the last called invlerp or transfer function to set theintensityused during max projection rendering.While we can't always guess exactly what should be the
emitIntensitywith multiple invlerps it might be a more reasonable heuristic to take the max across all the invlerps / transferFunctions instead of the current behaviour. This would also need some tweaking for what to do when the mode ismininstead ofmax.Opening this to discuss that possibility. Will need to update some documentation about the rendering if this heuristic is used instead of the current one. cc @fcollman as this came up from an example
I guess the alternative is that maybe this wouldn't come up as a problem if we can adjust the blending across multiple channels when each channel is it's own layer