feat: interpolation in shader UI controls invlerp/transfer function and use interpolation in multi-channel setup for volume rendering#855
Open
seankmartin wants to merge 10 commits intogoogle:masterfrom
Conversation
Collaborator
|
I suppose it may commonly be desired to have interpolation enabled for volume rendering and disabled otherwise, which indeed makes it less useful to have as a property of the invlerp control unless we also add separate volume rendering and non-volume rendering options. |
Contributor
Author
|
Thanks Jeremy, I think maybe best to go down a route similar to Option 1 for now then. Unsure what would be clearer for the user in the shader. Could do something like: As opposed to an overload of the Edit: just realised we can't do that because we could get redefinition if the user has another invlerp called |
Contributor
Author
Contributor
|
code looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an interpolation parameter to the
invlerpandtransferFunctionshader ui controls, which enables trilinear interpolation when sampling the data. The default remains as using the nearest neighbour.New parameter