Skip to content

fix: refactor RSA bits to remove unneeded classes#733

Merged
kevmoo merged 2 commits intomasterfrom
auth_crypto-cleanup
Mar 14, 2026
Merged

fix: refactor RSA bits to remove unneeded classes#733
kevmoo merged 2 commits intomasterfrom
auth_crypto-cleanup

Conversation

@kevmoo
Copy link
Copy Markdown
Collaborator

@kevmoo kevmoo commented Mar 13, 2026

And flagged members to ensure they are not exposed publicly

And flagged members to ensure they are not exposed publicly
@gemini-code-assist
Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@github-actions
Copy link
Copy Markdown

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
googleapis_auth None 2.2.0 2.2.1-wip 2.2.1-wip ✔️

This check can be disabled by tagging the PR with skip-breaking-check.

Unused Dependencies ✔️
Package Status
googleapis_auth ✔️ All dependencies utilized correctly.

For details on how to fix these, see dependency_validator.

This check can be disabled by tagging the PR with skip-unused-dependencies-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

License Headers ✔️
//
Files
no missing headers

All source files should start with a license header.

This check can be disabled by tagging the PR with skip-license-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

@kevmoo
Copy link
Copy Markdown
Collaborator Author

kevmoo commented Mar 14, 2026

/gemini review

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors parts of the RSA implementation to improve code structure and encapsulation. The RSAAlgorithm class, which was a container for static methods, has been removed, and its methods are now top-level functions within lib/src/crypto/rsa.dart. This change aligns with Dart best practices. Additionally, the visibility of these functions and the RS256Signer class has been restricted using @internal and @visibleForTesting annotations, effectively hiding implementation details from the public API. The changes are consistently applied across the codebase, including updates to tests. Overall, this is a solid refactoring that enhances maintainability.

@kevmoo kevmoo merged commit ac4f2bd into master Mar 14, 2026
34 checks passed
@kevmoo kevmoo deleted the auth_crypto-cleanup branch March 14, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant