fix: refactor RSA bits to remove unneeded classes#733
Conversation
And flagged members to ensure they are not exposed publicly
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
PR HealthBreaking changes ✔️
This check can be disabled by tagging the PR with Unused Dependencies ✔️
For details on how to fix these, see dependency_validator. This check can be disabled by tagging the PR with Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with License Headers ✔️
All source files should start with a license header. This check can be disabled by tagging the PR with API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors parts of the RSA implementation to improve code structure and encapsulation. The RSAAlgorithm class, which was a container for static methods, has been removed, and its methods are now top-level functions within lib/src/crypto/rsa.dart. This change aligns with Dart best practices. Additionally, the visibility of these functions and the RS256Signer class has been restricted using @internal and @visibleForTesting annotations, effectively hiding implementation details from the public API. The changes are consistently applied across the codebase, including updates to tests. Overall, this is a solid refactoring that enhances maintainability.
And flagged members to ensure they are not exposed publicly