feat: Remove Google App Engine standard support#4152
feat: Remove Google App Engine standard support#4152stevehipwell wants to merge 2 commits intogoogle:masterfrom
Conversation
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
gmlewis
changed the title
gmlewis
added
NeedsReview
gmlewis
changed the title
gmlewis
removed
the
Breaking API Change
gmlewis
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4152 +/- ##
==========================================
+ Coverage 93.76% 93.83% +0.07%
==========================================
Files 211 209 -2
Lines 19701 19685 -16
==========================================
Hits 18472 18472
+ Misses 1031 1015 -16
Partials 198 198 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @stevehipwell.
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
cc: @alexandear - @zyfy29 - @Not-Dhananjay-Mishra - @munlicode
Not-Dhananjay-Mishra
left a comment
Not-Dhananjay-Mishra
left a comment
There was a problem hiding this comment.
LGTM. Just one small question
|
|
||
| // withContext returns a shallow copy of req with its context changed to ctx. | ||
| func withContext(ctx context.Context, req *http.Request) *http.Request { | ||
| return req.WithContext(ctx) | ||
| } |
There was a problem hiding this comment.
Why do we need this helper function? Why can’t we directly use req.WithContext(ctx) where needed?
There was a problem hiding this comment.
@Not-Dhananjay-Mishra I kept it in as it's going to be removed in #4151 and I didn't want to modify more files than required in this PR.
3 participants
This PR removes support for Google App Engine Classic (Go < 1.12) including removing the
appenginebuild tag.This change is required for #4151.