rust: implement glome verify subcommand#200
Merged
pkern merged 1 commit intogoogle:masterfrom Feb 24, 2025
Merged
Conversation
pkern
requested changes
Feb 17, 2025
Member
pkern
left a comment
There was a problem hiding this comment.
Generally LGTM but one question.
| tag_b64.truncate(tag_b64.len() - 1); | ||
| } | ||
|
|
||
| // Ensure that we're comparing at least one byte. |
Member
There was a problem hiding this comment.
So the minimum tag length would need to be checked by the caller of verify, right? I weakly feel that this is surprising behavior and there should be some minimum tag length setting/flag that you need to pass. I could be convinced otherwise.
Collaborator
Author
There was a problem hiding this comment.
Makes sense, yes. I added a flag for this and set the default as we do in login.h.
b0b9cb9 to
6da33cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
verifysubcommand to the Rust CLI. Input tags can be truncated outputs of thetagsubcommand (i.e., in base64-encoded form), the minimum size of a tag can be adjusted with a flag.Closes #188.