[Open for discussion] Refine dependencies#897
Conversation
|
Maybe avatar and pandora should be removed from |
|
I think it's a great idea to make the dependencies more modular. It seems that dependency groups are usually intended for developer-focused options (doc, tests, ...) not end users. So, for instance, transports would not really be a dependency group. Those would be optional dependencies. |
803c6c6 to
ffcd751
Compare
|
I think this PR goes in the right direction. It is unfortunate that there isn't a way to specify a "default" for when no optional dependencies are specified, so this will create a breaking change for users, which we'll have to deal with by documenting the change well, and maybe also trying to print out useful errors when we can. |
(I haven't updated documentation because I think there will be some discussions)
Our dependency groups is a bit complicated right now. There have been some small problems like:
So here we apply some changes:
[dependency-groups]alloption including all other optionsappandtransportoptionsappdirswithplatformdirsAlso some questions:
platform_system!='Emscripten'condition? I am not pretty sure how does dependency for pyodide work.